Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenient GossipSync variant constructors #1618

Merged
merged 1 commit into from Jul 15, 2022

Conversation

wpaulino
Copy link
Contributor

These constructors fill in the missing types for each variant so that users don't have to turbofish them manually.

I verified that we could use all of these within ldk-sample without needing to turbofish.

Fixes #1594.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2022

Codecov Report

Merging #1618 (f3cb61f) into main (f3d5b94) will decrease coverage by 0.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1618      +/-   ##
==========================================
- Coverage   91.07%   90.81%   -0.26%     
==========================================
  Files          80       80              
  Lines       44128    44645     +517     
  Branches    44128    44645     +517     
==========================================
+ Hits        40190    40546     +356     
- Misses       3938     4099     +161     
Impacted Files Coverage Δ
lightning-background-processor/src/lib.rs 95.20% <ø> (ø)
lightning-invoice/src/payment.rs 87.76% <0.00%> (-5.15%) ⬇️
lightning/src/util/events.rs 39.25% <0.00%> (-2.74%) ⬇️
lightning/src/routing/scoring.rs 96.10% <0.00%> (-0.71%) ⬇️
lightning/src/routing/gossip.rs 91.32% <0.00%> (-0.63%) ⬇️
lightning/src/util/ser.rs 90.77% <0.00%> (-0.58%) ⬇️
lightning/src/ln/payment_tests.rs 98.73% <0.00%> (-0.53%) ⬇️
lightning/src/ln/msgs.rs 86.49% <0.00%> (-0.32%) ⬇️
lightning/src/ln/functional_tests.rs 96.80% <0.00%> (-0.31%) ⬇️
lightning-net-tokio/src/lib.rs 76.85% <0.00%> (-0.31%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3d5b94...f3cb61f. Read the comment docs.

jkczyz
jkczyz previously approved these changes Jul 15, 2022
lightning-background-processor/src/lib.rs Outdated Show resolved Hide resolved
lightning-background-processor/src/lib.rs Outdated Show resolved Hide resolved
jkczyz
jkczyz previously approved these changes Jul 15, 2022
lightning-background-processor/src/lib.rs Outdated Show resolved Hide resolved
These constructors fill in the missing types for each variant so that
users don't have to turbofish them manually.
@TheBlueMatt TheBlueMatt merged commit 9d35026 into lightningdevkit:main Jul 15, 2022
@TheBlueMatt TheBlueMatt added this to the 0.0.110 milestone Jul 15, 2022
@wpaulino wpaulino deleted the gossip-sync-constructors branch July 15, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GossipSync Constructors
4 participants