Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PeerManager::new_routing_only incompatible with lightning-net-tokio #1536

Closed
jkczyz opened this issue Jun 10, 2022 · 2 comments
Closed

PeerManager::new_routing_only incompatible with lightning-net-tokio #1536

jkczyz opened this issue Jun 10, 2022 · 2 comments
Assignees
@G8XSU
Labels
good first issue Good for newcomers
Milestone
0.0.110

Comments

@jkczyz
Copy link
Contributor

jkczyz commented Jun 10, 2022

PeerManager::new_routing_only (and PeerManager::new_channel_only) doesn't work with lightning-net-tokio because setup_inbound and setup_outbound take a PeerManager with Arc parameters but the PeerManager::new_routing_only returns a PeerManager without using an Arc for the RoutingMessageHandler.

Reported by a participant at the Bitcoin++ hackathon. Workaround is to instantiated the PeerManager using an Arc for the parameter instead of using PeerManager::new_routing_only.
@TheBlueMatt TheBlueMatt added this to the 0.0.109 milestone Jun 13, 2022
@TheBlueMatt
Copy link
Collaborator

Yuck. We should make the generic parameters in lightning-net-tokio more..generic and let them be Deref + Sync or whatever is needed to make tokio happy.

@TheBlueMatt TheBlueMatt added the good first issue Good for newcomers label Jun 22, 2022
@TheBlueMatt TheBlueMatt modified the milestones: 0.0.109, 0.0.110 Jun 22, 2022
@TheBlueMatt TheBlueMatt mentioned this issue Jul 20, 2022
Merged
@wpaulino
Copy link
Contributor

#1623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@G8XSU G8XSU

Labels
good first issue Good for newcomers
Projects
LDK Roadmap
Status: Done
Milestone
0.0.110
Development

No branches or pull requests
4 participants
@TheBlueMatt @G8XSU @jkczyz @wpaulino