Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProbabilisticScorer learning-from-probes interface #1385

Closed
TheBlueMatt opened this issue Mar 25, 2022 · 4 comments · Fixed by #1567
Closed

ProbabilisticScorer learning-from-probes interface #1385

TheBlueMatt opened this issue Mar 25, 2022 · 4 comments · Fixed by #1567
Milestone

Comments

@TheBlueMatt
Copy link
Collaborator

While you can do it already, passing information about a successful probe into ProbabilisticScorer is somewhat confusing today - you have to do it by calling the payment-failed method with a bogus scid to "blame". We should just wrap that call in a util function and expose it officially.

cc @jkczyz

@TheBlueMatt TheBlueMatt added this to the 0.1.1 milestone Mar 25, 2022
@jkczyz
Copy link
Contributor

jkczyz commented Mar 25, 2022

We may want to expand this issue to implement a background prober, which would actively probe paths in NetworkGraph with various amounts to learn the liquidity balances. It would need an EventHandler that could distinguish its probes from actual payments. In the former case, it would need to call the scorer with a fake failed scid as noted. Otherwise, delegate to the actual event handler.

@TheBlueMatt
Copy link
Collaborator Author

Another behavior I'm observing with the new scorer (at least with the settings on latest git) - it sometimes gets really excited when it finds a path that works, and tends to strongly prefer things it is confident will work over things its unsure about. that's probably a great outcome during normal payments, cause it seems to often be correct, but when we build a first-class prober, we should definitely make sure the prober is forced to probe each available channel we have outbound capacity on, instead of getting stuck using one, should be easy to do, though, just filter the ChannelDetailss we pass through and walk through them as we probe.

@tnull tnull linked a pull request Jun 28, 2022 that will close this issue
@TheBlueMatt
Copy link
Collaborator Author

Oops, 1567 didn't actually end up adding any prober logic in the scorer, which was the point of this issue.

@TheBlueMatt TheBlueMatt reopened this Jul 7, 2022
@TheBlueMatt
Copy link
Collaborator Author

This has been done for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants