Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better document distinction between channel/chain monitor #98

Open
ConorOkus opened this issue Nov 29, 2021 · 4 comments
Open

Better document distinction between channel/chain monitor #98

ConorOkus opened this issue Nov 29, 2021 · 4 comments

Comments

@ConorOkus
Copy link
Contributor

For some/many users, a unified API would be preferable. Abstraction layer might be convenient?

@TheBlueMatt
Copy link
Contributor

ChainMonitor is the abstraction layer. I'm not entirely sure what's to be done here?

@ConorOkus
Copy link
Contributor Author

Is there a preferred module to use here, as it seems like ChainMonitor & ChannelMonitor do quite similar things?

Opened this as there seemed to be confusion from one of our users, @arik-so any thoughts?

I'm happy to close if we feel it's a non issue.

@arik-so
Copy link
Contributor

arik-so commented Nov 30, 2021

I think the confusion stems from the objects sounding so similar, even though they clearly refer to very different components. This is a hard one, but imo, definitely a big source of confusion.

@TheBlueMatt
Copy link
Contributor

Hmm, they do sound somewhat similar. Some of the confusion may stem from the fact that we have a generic interface a user could implement, but they probably want to just use a ChainMonitor. Is https://lightningdevkit.org/architecture/ not clear on this matter, or should we increase visibility of that page?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants