Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/remove remaining references to KeysInterface #229

Open
tnull opened this issue Sep 11, 2023 · 2 comments
Open

Update/remove remaining references to KeysInterface #229

tnull opened this issue Sep 11, 2023 · 2 comments

Comments

@tnull
Copy link
Contributor

tnull commented Sep 11, 2023

See #226 (comment)

@tnull
Copy link
Contributor Author

tnull commented Dec 4, 2023

@ConorOkus I don't think this is completed, the occurances of KeysInterface the above comment mentions are still present in current main? For example:

If you are not using `KeysManager` for keys generation, you must re-derive the private keys yourself. Any `ChannelSigner` object must provide a unique id via the `channel_keys_id` function, whose value is provided back to you in the `SpendableOutputs` objects. A `SpendableOutputDescriptor::StaticOutput` element does not have this information as the output is sent to an output which used only `KeysInterface` data, not per-channel data.

and the .as_KeysInterface() occurrences in the Java examples of docs/tutorials/build_a_node_in_java.md and docs/payments/receiving_payments.md.

@ConorOkus ConorOkus reopened this Dec 8, 2023
@ConorOkus
Copy link
Contributor

Ahh thanks, I can get to these next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants