Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement invalid-parameters-error in LSPS1 / LSPS2 #98

Open
tnull opened this issue Jan 25, 2024 · 0 comments
Open

Implement invalid-parameters-error in LSPS1 / LSPS2 #98

tnull opened this issue Jan 25, 2024 · 0 comments

Comments

@tnull
Copy link
Collaborator

tnull commented Jan 25, 2024

When we dropped versioning support a new error type was introduced: invalid-parameters-error (see https://github.com/BitcoinAndLightningLayerSpecs/lsp/tree/main/LSPS0#-32602-invalid-parameters-error).

We currently don't return it, but should, at least if it's not too cumbersome.

Other implementors before mentioned that it's not trivial to do with serde, if it's too cumbersome we might want to bring it back to the spec group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant