Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider including gossip data field in list_channels #234

Open
tnull opened this issue Jan 31, 2024 · 2 comments
Open

Consider including gossip data field in list_channels #234

tnull opened this issue Jan 31, 2024 · 2 comments

Comments

@tnull
Copy link
Collaborator

tnull commented Jan 31, 2024

While LDK's ChannelManager doesn't have immediate access to gossip data, LDK Node does.

We therefore at least could consider to add additional (gossip) data fields to the ChannelDetails returned from list_channel, e.g., the counterparty's node announcement, allowing the user to access the node alias for displaying purposes.

@reez
Copy link

reez commented Jan 31, 2024

Thanks would love node alias!

@tnull
Copy link
Collaborator Author

tnull commented Feb 1, 2024

Mh, thinking about it again it's pretty tricky to this reliably on 'mostly-offline' nodes such as mobile devices, as RGS won't ship us any node announcements. So the optional field in ChannelDetails would be very unreliable, and only populated after we happen to receive a rebroadcast of our counterparty's node announcement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants