You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should allow to override our fee estimation for methods like Node::send_to_onchain_address.
It would however make sense to expose this as an Option<bitcoin::FeeRate> in the API. To avoid immediately breaking API again, we should therefore wait until we could upgrade to rust-bitcoin 0.30 which introduced FeeRate.
The text was updated successfully, but these errors were encountered:
It seems like bdk is using its own FeeRate in the tx builder, if we are using bitcoin::FeeRate I guess we should convert from bitcoin::FeeRate to bdk::FeeRate as well?
It seems like bdk is using its own FeeRate in the tx builder, if we are using bitcoin::FeeRate I guess we should convert from bitcoin::FeeRate to bdk::FeeRate as well?
Mhh, they are planning to drop their implementation for bitcoin::FeeRate for quite a while now and seem like they are close to finally pulling the trigger (see bitcoindevkit/bdk#1136 / bitcoindevkit/bdk#1216). I'd really avoid to introduce too many unnecessary conversions and churn in exposed types, which is why I deferred doing this until the BDK 1.0 upgrade.
I still tend towards this, but if you're eager to pick it up right now we could indeed consider exposing bitcoin::FeeRate in the API, converting from/to bdk::FeeRate.
We should allow to override our fee estimation for methods like
Node::send_to_onchain_address
.It would however make sense to expose this as an
Option<bitcoin::FeeRate>
in the API. To avoid immediately breaking API again, we should therefore wait until we could upgrade torust-bitcoin
0.30 which introducedFeeRate
.The text was updated successfully, but these errors were encountered: