Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set max_total_routing_fee_msat #166

Open
tnull opened this issue Sep 27, 2023 · 0 comments
Open

Allow to set max_total_routing_fee_msat #166

tnull opened this issue Sep 27, 2023 · 0 comments
Milestone

Comments

@tnull
Copy link
Collaborator

tnull commented Sep 27, 2023

LDK 0.0.117 introduces a new parameter for limiting the maximum total routing fee for any given payment.

While LDK sets a default value of 1% of the payment value plus 50_000 msat, we should allow the user to override this field.

However, it's not immediately clear how to do it best: adding a general default setting to Config seems a bit rigid, however, we'll probably don't want to clutter the interface by adding it as an optional parameter to all send_ calls.

However, we could consider introducing a PaymentParameters struct that would allow users to override multiple values. If we go this route, we should consider how much of upstream's RouteParameters we want to replicate here.

@tnull tnull added this to the 0.2 milestone Sep 27, 2023
@tnull tnull mentioned this issue Sep 27, 2023
9 tasks
@tnull tnull modified the milestones: 0.2, 0.3 Nov 15, 2023
@tnull tnull modified the milestones: 0.3, 0.4 May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant