Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wrapper types for txid/block hash #104

Open
TheBlueMatt opened this issue May 16, 2023 · 2 comments
Open

Add Wrapper types for txid/block hash #104

TheBlueMatt opened this issue May 16, 2023 · 2 comments

Comments

@TheBlueMatt
Copy link
Collaborator

People are always confused that the byte order is swapped when logging/printing to hex, so we should have a wrapper type that does that.

@tnull
Copy link

tnull commented May 16, 2023

Just as an idea: would it make sense to add such types in the regular lightning or a lightning-types crate to have consistency and DRYness over multiple projects?

@TheBlueMatt
Copy link
Collaborator Author

We could, but we currently use the rust-bitcoin types which makes sense, so I'm not sure if we should be rebuilding a wrapper that serves the same purpose on the lightning side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants