From f7698825a7717aa1b6f43d046b04d06713c4d4f4 Mon Sep 17 00:00:00 2001 From: Romain Thomas Date: Sun, 28 Apr 2024 17:30:25 +0200 Subject: [PATCH] Cleanup --- include/LIEF/PE/signature/ContentInfo.hpp | 8 ++++---- src/PE/signature/ContentInfo.cpp | 8 +------- 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/include/LIEF/PE/signature/ContentInfo.hpp b/include/LIEF/PE/signature/ContentInfo.hpp index c7ef086aac..dfcd11a528 100644 --- a/include/LIEF/PE/signature/ContentInfo.hpp +++ b/include/LIEF/PE/signature/ContentInfo.hpp @@ -99,16 +99,16 @@ class LIEF_API ContentInfo : public Object { return os; } - ~Content() override; + ~Content() override = default; private: oid_t type_; }; ContentInfo(); ContentInfo(const ContentInfo& other); - ContentInfo(ContentInfo&& other); + ContentInfo(ContentInfo&& other) noexcept = default; ContentInfo& operator=(ContentInfo other); - void swap(ContentInfo& other); + void swap(ContentInfo& other) noexcept; //! Return the OID that describes the content wrapped by this object. //! It should match SPC_INDIRECT_DATA_OBJID (1.3.6.1.4.1.311.2.1.4) @@ -134,7 +134,7 @@ class LIEF_API ContentInfo : public Object { void accept(Visitor& visitor) const override; - ~ContentInfo() override; + ~ContentInfo() override = default; LIEF_API friend std::ostream& operator<<(std::ostream& os, const ContentInfo& content_info); diff --git a/src/PE/signature/ContentInfo.cpp b/src/PE/signature/ContentInfo.cpp index 22446d42ba..ee3850f801 100644 --- a/src/PE/signature/ContentInfo.cpp +++ b/src/PE/signature/ContentInfo.cpp @@ -28,12 +28,6 @@ namespace LIEF { namespace PE { -ContentInfo::~ContentInfo() = default; - -ContentInfo::Content::~Content() = default; - -ContentInfo::ContentInfo(ContentInfo&& other) = default; - ContentInfo::ContentInfo() : value_(std::make_unique()) {} @@ -48,7 +42,7 @@ ContentInfo& ContentInfo::operator=(ContentInfo other) { return *this; } -void ContentInfo::swap(ContentInfo& other) { +void ContentInfo::swap(ContentInfo& other) noexcept { std::swap(value_, other.value_); }