Improve brush type #245
Merged
Improve brush type #245
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Somewhere along the way the possibility of brush being undefined must have been ignored/lost, or else this error should have been caught at compile time. Let's fix that, too. |
niklasf
requested changes
Jan 15, 2023
niklasf
added a commit
to niklasf/chessground
that referenced
this pull request
Jan 22, 2023
A particular small set of brushes (green, red, blue, yellow) can be selected for drawing while holding various keys. These are mandatory. By default, some more brushes are also available (paleGreen, paleRed, paleBlue, paleGrey) for programmatic usage. All can be overwritten, and more can be configured, so long as the 4 mandatory ones exist.
|
Sorry for the delay. Merged now. I also refreshed my understanding of the drawing code, and tweaked it a bit more: 8eef51c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brush in DrawShape is currently typed as string | undefined.
Passing undefined to brush crashes when using setShapes(): Uncaught TypeError: brush is undefined (svg.ts:87)
So it should be atleast string type.
I also added the available colors to the brush property, from state.ts. Because if you pass black as a string it just crashes. It would be nice if the available colors are in the type.