Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ToASM Performance Issues #99

Merged
merged 2 commits into from Dec 16, 2021
Merged

Fix: ToASM Performance Issues #99

merged 2 commits into from Dec 16, 2021

Conversation

tigh-latte
Copy link
Contributor

Move away from string concat and to string builder.

@mergify mergify bot added the bug-P3 label Dec 15, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2021

Codecov Report

Merging #99 (71b68a0) into master (18b76ae) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage   83.75%   83.76%   +0.01%     
==========================================
  Files          35       35              
  Lines        3668     3671       +3     
==========================================
+ Hits         3072     3075       +3     
  Misses        428      428              
  Partials      168      168              
Impacted Files Coverage Δ
bscript/script.go 62.33% <100.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18b76ae...71b68a0. Read the comment docs.

@mergify mergify bot merged commit 98953e2 into master Dec 16, 2021
@mergify mergify bot deleted the fix/to-asm-performance branch December 16, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants