Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CreateOpReturnOutput public #131

Merged
merged 17 commits into from Dec 6, 2022
Merged

Make CreateOpReturnOutput public #131

merged 17 commits into from Dec 6, 2022

Conversation

ordishs
Copy link
Collaborator

@ordishs ordishs commented Dec 6, 2022

No description provided.

@mergify mergify bot assigned ordishs Dec 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2022

Codecov Report

Base: 83.70% // Head: 83.70% // No change to project coverage 👍

Coverage data is based on head (9c6e5f0) compared to base (4208458).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #131   +/-   ##
=======================================
  Coverage   83.70%   83.70%           
=======================================
  Files          34       34           
  Lines        3701     3701           
=======================================
  Hits         3098     3098           
  Misses        434      434           
  Partials      169      169           
Impacted Files Coverage Δ
txoutput.go 81.73% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sirdeggen sirdeggen self-requested a review December 6, 2022 18:31
Copy link
Contributor

@sirdeggen sirdeggen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just need a comment now the function is public

@mergify mergify bot merged commit 4766f6a into libsv:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants