Fix for change and tiny fee calculations #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… some of the rounding needed re-visted as off by one bugs were noticed when calculating change. This has been remedied by using floating point as much as possible and using an int conversion as late as possible to ensure accurate figures. THis has resulted in some tests that had questionable results now becoming more accurate also.
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
==========================================
- Coverage 83.84% 83.82% -0.02%
==========================================
Files 34 34
Lines 3676 3672 -4
==========================================
- Hits 3082 3078 -4
Misses 427 427
Partials 167 167
Continue to review full report at Codecov.
|
jadwahab
requested changes
May 4, 2022
jadwahab
force-pushed
the
fix/change_rounding
branch
from
08d5dfa
to
96f9ef2
Compare
jadwahab
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the change to tiny dust limits and 0.05 sat / byte tx fee rates some of the rounding needed re-visited as off by one bugs were noticed when calculating change.
This has been remedied by using floating point as much as possible and using an int conversion as late as possible to ensure accurate figures.
This has resulted in some tests that had questionable results now becoming more accurate also.