Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Tx.Unlock refactor #100

Merged
merged 10 commits into from Dec 20, 2021
Merged

Enhancement: Tx.Unlock refactor #100

merged 10 commits into from Dec 20, 2021

Conversation

tigh-latte
Copy link
Contributor

No description provided.

@mergify mergify bot added the enhancement New feature or request label Dec 16, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2021 •
edited

Codecov Report

Merging #100 (2b29fcb) into master (18b76ae) will increase coverage by 0.08%.
The diff coverage is 72.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage   83.75%   83.84%   +0.08%     
==========================================
  Files          35       34       -1     
  Lines        3668     3676       +8     
==========================================
+ Hits         3072     3082      +10     
+ Misses        428      427       -1     
+ Partials      168      167       -1
Impacted Files Coverage Δ
unlocker/simple.go 65.00% <65.00%> (ø)
txinput.go 82.50% <72.00%> (-2.77%) ⬇️
bscript/interpreter/thread.go 94.30% <80.00%> (ø)
utxojson.go 54.09% <100.00%> (ø)
bscript/script.go 62.33% <0.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18b76ae...2b29fcb. Read the comment docs.

@jadwahab jadwahab marked this pull request as draft December 17, 2021 10:40
@tigh-latte tigh-latte changed the title Enhancement: Rename Tx.Unlock and Tx.UnlockAll to Tx.SignOff and Tx.SignOffAll Enhancement: Rename Tx.Unlock and Tx.UnlockAll to Tx.UnlockInput and Tx.UnlockAllInputs Dec 17, 2021
Tíghearnán Carroll and others added 5 commits December 17, 2021 12:17
renamed test var
eafb89a
refactor!: remove useless funcs
787dfa7 
fix localUnlocker check at the beginning
ApplyUnlockingScript -> InsertInputUnlockingScript
WIP: refactor
62ae674
big change
c986953
fixed linter
dd03fc5
@tigh-latte tigh-latte changed the title Enhancement: Rename Tx.Unlock and Tx.UnlockAll to Tx.UnlockInput and Tx.UnlockAllInputs Enhancement: Tx.Unlock refactor Dec 17, 2021
jadwahab
jadwahab approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@jadwahab jadwahab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@jadwahab jadwahab linked an issue Dec 17, 2021 that may be closed by this pull request
Unlocker improvements #101
Closed
@tigh-latte tigh-latte marked this pull request as ready for review December 20, 2021 15:06
@mergify mergify bot merged commit e724ab8 into master Dec 20, 2021
@mergify mergify bot deleted the enhancement/rename-unlock-to-signoff branch December 20, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirdeggen sirdeggen sirdeggen approved these changes

@jadwahab jadwahab jadwahab approved these changes

@theflyingcodr theflyingcodr Awaiting requested review from theflyingcodr

Assignees

@tigh-latte tigh-latte

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unlocker improvements
4 participants
@tigh-latte @codecov-commenter @sirdeggen @jadwahab