Fix build on architectures with unsigned char

[pkubaj]

ARM and POWER are affected.

[stappersg]

(Summary: the proposed patch did get human attention)

-        iface.ifr_name[i] = c as i8;
+        iface.ifr_name[i] = c as libc::c_char;

It is the libc:: that makes me wonder if that will block using libpnet in a no_std environment.

Would like to known if

-        iface.ifr_name[i] = c as i8;
+        iface.ifr_name[i] = c as c_char;

or even

-        iface.ifr_name[i] = c as i8;
+        iface.ifr_name[i] = c;

will compile (will work) on ARM and/of POWERPC.

(Feel free to render this comment as just noise.)

[pkubaj]

(Summary: the proposed patch did get human attention)

-        iface.ifr_name[i] = c as i8;
+        iface.ifr_name[i] = c as libc::c_char;

It is the libc:: that makes me wonder if that will block using libpnet in a no_std environment.

Would like to known if

-        iface.ifr_name[i] = c as i8;
+        iface.ifr_name[i] = c as c_char;

error[E0412]: cannot find type c_char in this scope

or even

-        iface.ifr_name[i] = c as i8;
+        iface.ifr_name[i] = c;

That indeed seems to work.

will compile (will work) on ARM and/of POWERPC.

(Feel free to render this comment as just noise.)

[infosechoudini]

can we push a new commit that doesnt have c_char?

[infosechoudini]

in the future, we'll look into other methods of building cross-os and cross-arch

[mrmonday]

Looks good thanks!