Add illumos support #549
Merged
Add illumos support #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, and is more-or-less what I'd expect from a new port - thank you for your work 🙂
|
solaris
error[E0308]: mismatched types
--> pnet_datalink/src/lib.rs:239:22
|
239 | self.flags & (pnet_sys::IFF_UP as u32) != 0
| ^^^^^^^^^^^^^^^^^^^^^^^^^ expected `u64`, found `u32`
error[E0277]: no implementation for `u64 & u32`
--> pnet_datalink/src/lib.rs:239:20
|
239 | self.flags & (pnet_sys::IFF_UP as u32) != 0
| ^ no implementation for `u64 & u32`
|
= help: the trait `BitAnd<u32>` is not implemented for `u64`
...
illumos and solaris, too warning: getting the inner pointer of a temporary `CString` --> src/bpf.rs:82:57 | 82 | CString::new(&b"/dev/bpf"[..]).unwrap().as_ptr(), | --------------------------------------- ^^^^^^ this pointer will be invalid | | | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime | = note: `#[warn(temporary_cstring_as_ptr)]` on by default = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned = help: for more information, see https://doc.rust-lang.org/reference/destructors.html
|
I'm going to go ahead and merge this - the tests can be fixed in a later PR, if you're interested in doing the work. Thanks for your work! |
wip-sync
pushed a commit
to NetBSD/pkgsrc-wip
that referenced
this pull request
Aug 10, 2022
Building garage 0.7.0+ on illumos requires patching the pnet_* deps to a newer version, which includes illumos support. See: https://github.com/libpnet/libpnet/releases/tag/v0.30.0 libpnet/libpnet#549
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt at adding illumos support.
Rust newcomer here, so any feedback is welcome.
Happy to improve this PR to hopefully get it merged one day.
EDIT:
Testing notes:
cargo teston linux is green but on illumos it shows this:EDIT2: But
make testsucceeds on both linux and illumos: