Re-add serde support to NetworkInterface #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me re-run the CI for figuring out CI failure root cause. |
In libpnet#255, the ipnetwork crate was added. IpNetwork did not yet support Serde, so (de)serialization support using such had to be removed. As of achanda/ipnetwork@c9e25e1, IpNetwork includes feature-gated serde support This snippet did not function prior to my changes, but seems to function fine after re-implementing serde support for IpNetwork ```rust pub fn get_network_interfaces() -> anyhow::Result<Value> { let raw_interfaces: Vec<NetworkInterface> = interfaces(); Ok(json!(raw_interfaces)) } ``` Since this is now supported upstream, it seems like a low-risk change.
mrmonday
force-pushed
the
feature/pnet-datalink/NetworkInterface-serde-support
branch
from
d618feb
to
0f7754f
Compare
|
Just rebased this, hopefully CI will pass now. |
|
CI is taking too long, gonna merge this and test locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #255, the ipnetwork crate was added.
IpNetwork did not yet support Serde, so (de)serialization support using such had to be removed.
As of achanda/ipnetwork@c9e25e1, IpNetwork includes feature-gated serde support
This snippet did not function prior to my changes, but seems to function
fine after re-implementing serde support for IpNetwork
Result:
[{"flags":65609,"index":1,"ips":["127.0.0.1/8","::1/128"],"mac":"00:00:00:00:00:00","name":"lo"},{"flags":69699,"index":2,"ips":["10.10.0.211/24","fe80::a9d:7071:53a:3da1/64"],"mac":"08:62:66:45:70:18","name":"eno1"},{"flags":4099,"index":3,"ips":["172.17.0.1/16"],"mac":"02:42:91:88:fa:1e","name":"docker0"}]I understand there was question as to whether this feature was useful, but it seems appropriate to enable it in this case, especially since it is now supported upstream, and requires minimal effort in terms of maintenance for this repository (as far as I understand).