Fix undefined behavior in packet field setters #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failed with failed to load source for dependency |
This was referenced Nov 27, 2020
It is currently possible to trigger undefined behavior in field setters created by the `packet` macro, such as `MutableIpv4Packet::set_payload`, by setting a buffer larger than the remaining space in the packet buffer. Fix this by replacing the unsafe `copy_nonoverlapping` call with `copy_from_slice`. This function still compiles to `memcpy`, but includes a range check which which will panic if the destination buffer is too small. Fixes libpnet#449. Fixes libpnet#411.
mrmonday
force-pushed
the
set_payload_overrun
branch
from
cba56e8
to
dde31d2
Compare
|
Just rebased this, hopefully CI will pass now. |
|
CI is taking too long, gonna merge this and test it locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is currently possible to trigger undefined behavior in field setters
created by the
packetmacro, such asMutableIpv4Packet::set_payload,by setting a buffer larger than the remaining space in the packet
buffer.
Fix this by replacing the unsafe
copy_nonoverlappingcall withcopy_from_slice. This function still compiles tomemcpy, butincludes a range check which which will panic if the destination buffer
is too small.
Fixes #449. Fixes #411.