Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-peer: Identify Protocol String #66

Open
DougAnderson444 opened this issue May 4, 2023 · 4 comments
Open

rust-peer: Identify Protocol String #66

DougAnderson444 opened this issue May 4, 2023 · 4 comments

Comments

@DougAnderson444
Copy link
Contributor

DougAnderson444 commented May 4, 2023

Is this supposed to be ipfs/id/1.0.0 (with /id/ in the middle) as per this page

let identify_config = identify::Behaviour::new(
identify::Config::new("/ipfs/0.1.0".into(), local_key.public())

@DougAnderson444
Copy link
Contributor Author

DougAnderson444 commented May 4, 2023

Did a bit more digging, perhaps it's more ipfs/0.1.0 needs to be added to that libp2p protocol page?

@mxinden
Copy link
Member

mxinden commented May 8, 2023

For the sake of completeness, adding to the latest comment, the referenced /ipfs/0.1.0 is not the libp2p identify multistream-select protool name, but the general libp2p Protocol Version, see https://github.com/libp2p/specs/tree/master/identify#protocolversion.

@mxinden
Copy link
Member

mxinden commented May 8, 2023

As far as I am aware, universal-connectivity nodes should not interact, nor act as normal IPFS nodes, thus they should like choose a different Protocol Version, e.g. /universal-connectiviy/0.1.0. That said, I am not aware of any code-path that actually acts upon the Protocol Version, thus this would be for humans only.

@DougAnderson444
Copy link
Contributor Author

Thank @mxinden, I can appreciate your input here.

I am working on a plugin system idea for libp2p where this protocol name/version would come in handy to find other peers who run the same plugin protocol. Given there is no code path though, and usage seems to be a bit diverse across implementation, what would be the best approach? Could I build on what is already there effectively?

@2color 2color changed the title Protocol String Identify Protocol String Apr 29, 2024
@2color 2color changed the title Identify Protocol String rust-peer: Identify Protocol String Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants