Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Update parking_lot requirement from 0.11.0 to 0.12.0 #2463

Merged
merged 4 commits into from Feb 16, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 31, 2022

Updates the requirements on parking_lot to permit the latest version.

Changelog

Sourced from parking_lot's changelog.

parking_lot 0.12.0, parking_lot_core 0.9.0, lock_api 0.4.6 (2022-01-28)

  • The MSRV is bumped to 1.49.0.
  • Disabled eventual fairness on wasm32-unknown-unknown. (#302)
  • Added a rwlock method to report if lock is held exclusively. (#303)
  • Use new asm! macro. (#304)
  • Use windows-rs instead of winapi for faster builds. (#311)
  • Moved hardware lock elision support to a separate Cargo feature. (#313)
  • Removed used of deprecated spin_loop_hint. (#314)

parking_lot 0.11.2, parking_lot_core 0.8.4, lock_api 0.4.5 (2021-08-28)

  • Fixed incorrect memory orderings on RwLock and WordLock. (#294, #292)
  • Added Arc-based lock guards. (#291)
  • Added workaround for TSan's lack of support for fence. (#292)

lock_api 0.4.4 (2021-05-01)

  • Update for latest nightly. (#281)

lock_api 0.4.3 (2021-04-03)

  • Added [Raw]ReentrantMutex::is_owned. (#280)

parking_lot_core 0.8.3 (2021-02-12)

  • Updated smallvec to 1.6. (#276)

parking_lot_core 0.8.2 (2020-12-21)

  • Fixed assertion failure on OpenBSD. (#270)

parking_lot_core 0.8.1 (2020-12-04)

  • Removed deprecated CloudABI support. (#263)
  • Fixed build on wasm32-unknown-unknown. (#265)
  • Relaxed dependency on smallvec. (#266)

parking_lot 0.11.1, lock_api 0.4.2 (2020-11-18)

  • Fix bounds on Send and Sync impls for lock guards. (#262)
  • Fix incorrect memory ordering in RwLock. (#260)

lock_api 0.4.1 (2020-07-06)

  • Add data_ptr method to lock types to allow unsafely accessing the inner data without a guard. (#247)

parking_lot 0.11.0, parking_lot_core 0.8.0, lock_api 0.4.0 (2020-06-23)

... (truncated)

Commits
  • a75875b Release parking_lot 0.12.0, parking_lot_core 0.9.0, lock_api 0.4.6
  • 78a16dd Minor fixes
  • 4d64bc6 Merge pull request #314 from Amanieu/spin_loop
  • a4e4a02 Only run CI for bors and pull requests
  • 930caab Use core::hint::spin_loop instead of the deprecated spin_loop_hint.
  • b3c9290 Merge pull request #313 from Amanieu/hle_feature
  • b271f84 Move hardware lock elision support to a separate Cargo feature
  • 8019473 Merge pull request #311 from clemenswasser/adopt-windows-rs
  • 1f94288 Adopt windows-rs
  • c73dd43 Merge pull request #309 from Amanieu/stable_asm
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Jan 31, 2022
@dependabot dependabot bot force-pushed the dependabot/cargo/parking_lot-0.12.0 branch 4 times, most recently from f87d103 to ef50958 Compare February 3, 2022 11:50
Updates the requirements on [parking_lot](https://github.com/Amanieu/parking_lot) to permit the latest version.
- [Release notes](https://github.com/Amanieu/parking_lot/releases)
- [Changelog](https://github.com/Amanieu/parking_lot/blob/master/CHANGELOG.md)
- [Commits](Amanieu/parking_lot@0.11.0...0.12.0)

---
updated-dependencies:
- dependency-name: parking_lot
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/cargo/parking_lot-0.12.0 branch from ef50958 to 5b626e2 Compare February 3, 2022 16:40
@mxinden
Copy link
Member

mxinden commented Feb 9, 2022

@PhilippGackstatter @wngr parking_lot removed the wasm-bindgen feature (Amanieu/parking_lot#302). Any advice on how to proceed here?

@PhilippGackstatter
Copy link
Contributor

I did a local test to see if a Wasm peer in node.js could still dial a non-Wasm peer, and that worked fine. Couldn't send a custom RequestResponse message (times out), but that issue was also present on 0.42.2, so I think it's unrelated to parking lot and I'll have to look into this again when we pick up our Wasm-libp2p work.

From reading the PR and associated issue, it seems like functionality wise nothing changed, and only the dependency on the instant crate was removed. So, I think the parking_lot/wasm-bindgen part of libp2p's wasm-bindgen feature can be removed without breaking anything downstream and the version can be updated to 0.12.

Copy link
Contributor

@wngr wngr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxinden mxinden merged commit 80bbb62 into master Feb 16, 2022
@dependabot dependabot bot deleted the dependabot/cargo/parking_lot-0.12.0 branch February 16, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants