Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce NewExternalAddrCandidate reports from identify #5319

Open
drHuangMHT opened this issue Apr 18, 2024 · 0 comments
Open

Reduce NewExternalAddrCandidate reports from identify #5319

drHuangMHT opened this issue Apr 18, 2024 · 0 comments

Comments

@drHuangMHT
Copy link
Contributor

Description

Report NewExternalAddrCandidate per instance, e.g. one instance of identify behaviour should only report external address candidate only once unless expired.

Motivation

NewExternalAddrCandidate event will not flood the event handling system during DHT walk-through.

Current Implementation

Currently NewExternalAddrCandidate is reported per connection, e.g. the same connection won't report already reported addresses but new connection will. So when bootstraping a DHT network NewExternalAddrCandidate will flood in.

Are you planning to do it yourself in a pull request ?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant