Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mergify continously approving approved pull requests #5207

Open
mxinden opened this issue Mar 4, 2024 · 6 comments
Open

mergify continously approving approved pull requests #5207

mxinden opened this issue Mar 4, 2024 · 6 comments

Comments

@mxinden
Copy link
Member

mxinden commented Mar 4, 2024

Summary

Mergify seems to continously approve already approved pull requests. See e.g. #5206.

Expected behavior

Approve once.

Actual behavior

Approve ~ every mintue.

Relevant log output

No response

Possible Solution

No response

Version

No response

Would you like to work on fixing this bug ?

No

@mxinden
Copy link
Member Author

mxinden commented Mar 4, 2024

I paused all merge queues, thus far without success.

https://dashboard.mergify.com/github/libp2p/repo/rust-libp2p/queues?branch=master&queues=default

@mxinden
Copy link
Member Author

mxinden commented Mar 4, 2024

Potential hot-fix: #5208

@mxinden
Copy link
Member Author

mxinden commented Mar 4, 2024

#5208 did the trick. I unpaused the merge queue.

@jxs
Copy link
Member

jxs commented Mar 4, 2024

thanks Max, it seems mergify approves but doesn't add the send-it label right?
With your hotfix we now need to manually approve the deps PR's from dependabot right?

@mxinden
Copy link
Member Author

mxinden commented Mar 4, 2024

thanks Max, it seems mergify approves but doesn't add the send-it label right?

Did it ever? As far as I can tell, it simply enqueues it right away:

- name: Add approved dependabot PRs to merge queue
conditions:
# All branch protection rules are implicit: https://docs.mergify.com/conditions/#about-branch-protection
- author=dependabot[bot]
- base=master
actions:
queue:

@mxinden
Copy link
Member Author

mxinden commented Mar 4, 2024

With your hotfix we now need to manually approve the deps PR's from dependabot right?

I don't know what the best process is. I don't think the PRs are urgent. Instead I suggest debugging the mergify issue first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants