mDNS: emit ToSwarm::NewExternalAddrOfPeer
#5104
Assignees
Labels
Comments
thomaseizinger
changed the title
ToSwarm::NewExternalAddrOfPeerToSwarm::NewExternalAddrOfPeer
|
would like to work on this |
|
would like to take this one once previous one time out. @thomaseizinger , unsure the policy here. |
|
Feel free to start! :) I've not heard from @1010adigupta so far. |
ah, ok, just afraid there's some duplicated work done. |
|
You can go for it, I got busy with some other stuff, didn't got time for this :) |
|
@thomaseizinger hey i have a question, isn't the mDNS service already inform Swarm when a new peer discovered? https://github.com/libp2p/rust-libp2p/blob/master/protocols/mdns/src/behaviour.rs#L351, what need to change here? |
4 tasks
|
It emits an mDNS specific event that the user has to react to manually. The idea of the new event is that it is shared with other behaviours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
With #4371 merged, we have the foundation of #4302 implemented.
libp2p-mdnsneeds to be extended to emit this new event whenever it discovers a new address via mDNS.Motivation
Other behaviours should be able to learn the addresses discovered by mDNS.
Current Implementation
Only mDNS knows about its discovered addresses.
Are you planning to do it yourself in a pull request ?
No
The text was updated successfully, but these errors were encountered: