Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kad: emit ToSwarm::NewExternalAddrOfPeer #5103

Open
thomaseizinger opened this issue Jan 21, 2024 · 6 comments
Open

kad: emit ToSwarm::NewExternalAddrOfPeer #5103

thomaseizinger opened this issue Jan 21, 2024 · 6 comments

Comments

@thomaseizinger
Copy link
Contributor

Description

With #4371 merged, we have the foundation of #4302 implemented.

libp2p-kad needs to be extended to emit this new event whenever it discovers a new address through the DHT.

Motivation

Other behaviours should be able to learn the addresses discovered by kademlia.

Current Implementation

Only kademlia knows about its discovered addresses.

Are you planning to do it yourself in a pull request ?

No

@1010adigupta
Copy link

would like to work on this

@1010adigupta
Copy link

would work on mDNS and DHT simultaneously, you can assign me this as well

@thomaseizinger
Copy link
Contributor Author

would work on mDNS and DHT simultaneously, you can assign me this as well

Make them two PRs please! :)

@justcode740
Copy link

unsure whether this one is taken but seem prev one has made such claim and not submit pattern in some other repo couple times..

@thomaseizinger
Copy link
Contributor Author

You are welcome to work on this too!

@blacktoast
Copy link

Hi, do you mind if I try to do this?

I know a little bit of Rust, but this is my first time contributing to a p2p related library, so if you don't mind, is there any code or documentation that would help me solve this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants