Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ping): make the ignoring of the first error configurable #5004

Open
stormshield-frb opened this issue Dec 11, 2023 · 0 comments · May be fixed by #5005
Open

feat(ping): make the ignoring of the first error configurable #5004

stormshield-frb opened this issue Dec 11, 2023 · 0 comments · May be fixed by #5005

Comments

@stormshield-frb
Copy link
Contributor

Description

Be able to configure, the fact to ignore or not the first error of ping::Handler::poll.

Motivation

In our project, we need to rapidly detect that an error may have occurred with ping. However, like it is described here, for interoperability reasons with the Javascript libp2p, the first error is silenced. We personally don't use the Javascript implementation so we would like to be able to catch the first error.

Current Implementation

There is no need to not ignore the first error.

Are you planning to do it yourself in a pull request ?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant