feat(tcp): make TCP_NODELAY the default #4916
Draft
+8
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhexists
changed the title
TCP_NODELAY the default
mxinden
reviewed
Nov 27, 2023
Co-authored-by: Max Inden <mail@max-inden.de>
|
Hi, apologies for the mistake. Fixed the function comment and added to the PR to the Changelog.md file |
thomaseizinger
requested changes
Nov 28, 2023
There was a problem hiding this comment.
@mxinden In my eyes, this is a breaking change and shouldn't be released as a patch-release.
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
|
Updated the Changelog and Cago.toml as asked @thomaseizinger |
|
Thanks! This is ready but we delay breaking changes for a while to batch them up. I marked it as draft so it doesn't get merged accidentally. Can you deal with the CI error? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #4890.
Notes
Added no delay to be Some(true) by default whenever the new method is called.