Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gossipsub: add test for missed heartbeats #3987

Open
thomaseizinger opened this issue May 25, 2023 · 3 comments
Open

gossipsub: add test for missed heartbeats #3987

thomaseizinger opened this issue May 25, 2023 · 3 comments
Labels
difficulty:moderate getting-started Issues that can be tackled if you don't know the internals of libp2p very well help wanted priority:nicetohave

Comments

@thomaseizinger
Copy link
Contributor

We should have a test that ensure we "catch" up to missed heartbeats. For the underlying timer, this means implementing a "skip" behavior.

The test should be on a Swarm level ideally such that we don't rely on implementation details.

The cherry on the cake would be to run the test in wasm as well to make sure the timer implementation is always sane.

Originally discussed in #3973 (comment)
@mxinden mxinden added help wanted getting-started Issues that can be tackled if you don't know the internals of libp2p very well priority:nicetohave difficulty:moderate labels May 29, 2023
@dgarus
Copy link
Contributor

dgarus commented Jun 13, 2023 •
edited

@thomaseizinger
Hi!
I'd like to take this issue, WDYT?

@thomaseizinger
Copy link
Contributor Author

It might be worth waiting for #4015 to be merged because it introduces WASM testing in CI.

@thomaseizinger
Copy link
Contributor Author

I started a discussion here because it is not clear to me what the best approach regarding wasm tests is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:moderate getting-started Issues that can be tackled if you don't know the internals of libp2p very well help wanted priority:nicetohave
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thomaseizinger @mxinden @dgarus