Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semver issues with libp2p-swarm-derive:0.30.1 - please yank #3029

Closed
Voxelot opened this issue Oct 14, 2022 · 2 comments
Closed

Semver issues with libp2p-swarm-derive:0.30.1 - please yank #3029

Voxelot opened this issue Oct 14, 2022 · 2 comments

Comments

@Voxelot
Copy link

Voxelot commented Oct 14, 2022 •
edited

Related to: #2907

When libp2p-swarm-derive:0.30.1 was released today, it started causing our libraries to fail to compile due to breaking changes in #2907 being released as a patch version. While the PR is a good improvement, we had already made the appropriate workarounds to deal with these generics in our own published crates.

My suggestion would be that libp2p should properly bump the version of libp2p-swarm-derive to 0.31.0 and yank 0.30.1 to avoid causing unexpected build failures for libp2p users.

cc @mxinden
@Voxelot Voxelot mentioned this issue Oct 14, 2022
Merged
@thomaseizinger
Copy link
Contributor

Can you post the piece of code that would compile before but doesn't now?

@mxinden
Copy link
Member

mxinden commented Dec 2, 2022

Closing here. @Voxelot please let us know in case you are still facing this issue.

@mxinden mxinden closed this as completed Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Voxelot @thomaseizinger @mxinden