Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a merge bot for merging PRs #3010

Closed
thomaseizinger opened this issue Oct 11, 2022 · 12 comments · Fixed by #3026
Closed

Use a merge bot for merging PRs #3010

thomaseizinger opened this issue Oct 11, 2022 · 12 comments · Fixed by #3026

Comments

@thomaseizinger
Copy link
Contributor

thomaseizinger commented Oct 11, 2022

Description

It is a bit tedious to manually babysit PRs and update + merge them one at a time. GitHub has merge queues in beta but it is not a public beta yet.

In the meantime, we could use https://mergify.com. It is free for open-source projects. It even has cool features like defining the commit message ahead of time in the PR description: https://docs.mergify.com/actions/merge/#commit-message-template

Open to other suggestions.

Motivation

Spend less time babysitting PRs.

Current Implementation

Are you planning to do it yourself in a pull request?

Yes.

@thomaseizinger
Copy link
Contributor Author

thomaseizinger commented Oct 13, 2022

Other things mergify could do for us:

@galargh
Copy link
Contributor

galargh commented Oct 13, 2022

GitHub has merge queues in beta but it is not a public beta yet.

Btw, I've been trying to get us into that beta for the better part of this year but no luck so far.

@jxs
Copy link
Member

jxs commented Oct 13, 2022

Thanks Thomas, I think it's a great idea, I think this paired with #2948 will improve a lot the merge and conflict resolution rate in the repo!

Request author to resolve conflicts: https://docs.mergify.com/actions/comment/#request-for-action

yeah if mergify has this feature (and it seems better cause it can tag the author of the PR) we should probably close #2958 and just use mergify

@thomaseizinger
Copy link
Contributor Author

I'll draft up an integration and then people can have a look!

@thomaseizinger
Copy link
Contributor Author

I requested permission for integration. Not sure who can grant this? @galargh @BigLep @mxinden?

@thomaseizinger thomaseizinger linked a pull request Oct 14, 2022 that will close this issue
4 tasks
@mxinden
Copy link
Member

mxinden commented Oct 14, 2022

I would assume @galargh is the best one to help here. Please ping me if that is not the case.

@galargh
Copy link
Contributor

galargh commented Oct 17, 2022

I do have permissions to accept the installation - I'll see it through. They do have some high-visibility customers which makes it seem quite trustworthy.

@BigLep, just to double-check, we do not have any specific process in place for vetting 3rd party integrations, right? Beyond the ask here, but I think it might be nice to have a clear checklist of what needs to happen to get a new app installed.

@BigLep
Copy link
Contributor

BigLep commented Oct 17, 2022

@galargh : Yeah, I'm not familiar with any. If you want to develop one, I'd ask @andyschwab may have had one he was mentally following in the past. Thanks for seeing it through.

@andyschwab
Copy link
Member

Pinging @galargh directly 👍

@galargh
Copy link
Contributor

galargh commented Oct 18, 2022

I and Andy are on it. Current status: we reached out to Mergify security team with a couple of questions. I'll keep you posted on the progress. FYI, a more formal process for things like this is in the works too.

@thomaseizinger
Copy link
Contributor Author

I and Andy are on it. Current status: we reached out to Mergify security team with a couple of questions. I'll keep you posted on the progress. FYI, a more formal process for things like this is in the works too.

Any update on this? :)

@galargh
Copy link
Contributor

galargh commented Nov 2, 2022

I and Andy are on it. Current status: we reached out to Mergify security team with a couple of questions. I'll keep you posted on the progress. FYI, a more formal process for things like this is in the works too.

Any update on this? :)

Mergify got back to us and it looks reasonable from the security standpoint. I just installed it for libp2p org (scoped to rust-libp2p repo - at least for now). We don't have any repo secrets currently set up here, so we don't have to prepare secret breach mitigation plan. However, if we ever add sensitive secrets here, we should revisit this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants