Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.git-blame-ignore-revs/: Initialize and add rustfmt commit #2864

Merged
merged 2 commits into from Sep 4, 2022

Conversation

thomaseizinger
Copy link
Contributor

@thomaseizinger thomaseizinger commented Sep 1, 2022

Description

Ignoring certain revisions helps in finding the "correct" commit
that touched a file last.

For more information, see:

https://www.git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revs-fileltfilegt

Links to any relevant issues

Open Questions

What is the correct title for this PR according to our naming guidelines?

Change checklist

- [ ] I have performed a self-review of my own code
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] A changelog entry has been made in the appropriate crates

Ignoring certain revisions helps in finding the "correct" commit
that touched a file last.

For more information, see:

https://www.git-scm.com/docs/git-blame#Documentation/git-blame.txt---ignore-revs-fileltfilegt
@thomaseizinger thomaseizinger changed the title /: Add .git-blame-ignore-revs Add .git-blame-ignore-revs Sep 1, 2022
@mxinden mxinden changed the title Add .git-blame-ignore-revs .git-blame-ignore-revs/: Initialize and add rustfmt commit Sep 4, 2022
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't aware of this git feature. Neat!

@mxinden mxinden merged commit f04df29 into master Sep 4, 2022
@mxinden
Copy link
Member

mxinden commented Sep 4, 2022

What is the correct title for this PR according to our naming guidelines?

I would suggest the following:

.git-blame-ignore-revs: Initialize and add rustfmt commit

(I accidentally merged with a / implying that it is a folder.)

@thomaseizinger
Copy link
Contributor Author

Wasn't aware of this git feature. Neat!

It still requires everyone to set the right config flag but as I documented, you can set it globally and there is a kind of convention about the name which makes it a do-once-and-forget-thing!

@thomaseizinger thomaseizinger deleted the git-blame-ignore-revs branch September 19, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants