Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocols/kad: Support multiple protocol names #2846

Merged

Conversation

dmitry-markin
Copy link
Contributor

Description

Add support for multiple Kademlia protocol names to allow protocol name upgrades.

Links to any relevant issues

Resolves #2837.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dmitry-markin for the patch!

protocols/kad/src/behaviour.rs Show resolved Hide resolved
protocols/kad/src/protocol.rs Outdated Show resolved Hide resolved
protocols/kad/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks @dmitry-markin for the follow-ups.

Would you do me a favor and prepare a pull request that removes the deprecated methods. This pull request we can merge once libp2p-kad v0.40.0 was released, thus removing the deprecated methods with libp2p-kad v0.41.0.

protocols/kad/CHANGELOG.md Outdated Show resolved Hide resolved
@mxinden mxinden changed the title Support multiple Kademlia protocol names protocols/kad: Support multiple protocol names Sep 2, 2022
@dmitry-markin
Copy link
Contributor Author

Would you do me a favor and prepare a pull request that removes the deprecated methods. This pull request we can merge once libp2p-kad v0.40.0 was released, thus removing the deprecated methods with libp2p-kad v0.41.0.

Sure, can do this. @mxinden, meanwhile, could you merge this PR — GitHub says "Only those with write access to this repository can merge pull requests."

@mxinden mxinden merged commit cee199a into libp2p:master Sep 3, 2022
@mxinden
Copy link
Member

mxinden commented Sep 3, 2022

@dmitry-markin do you need a new release soonish, or is depending on master unblocking you for now?

@dmitry-markin
Copy link
Contributor Author

@mxinden substrate consumes libp2p from crates.io, so having the changes released would be great. Nevertheless, it's not something super urgent.

@dmitry-markin
Copy link
Contributor Author

Would you do me a favor and prepare a pull request that removes the deprecated methods. This pull request we can merge once libp2p-kad v0.40.0 was released, thus removing the deprecated methods with libp2p-kad v0.41.0.

A follow-up PR that removes the deprecated methods: #2866.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the possibility to negotiate fallback Kademlia protocol names
2 participants