Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove flush_all from docs #2721

Closed
kpp opened this issue Jun 21, 2022 · 1 comment · Fixed by #2707
Closed

Remove flush_all from docs #2721

kpp opened this issue Jun 21, 2022 · 1 comment · Fixed by #2707

Comments

@kpp
Copy link
Contributor

kpp commented Jun 21, 2022 •
edited

rust-libp2p/core/src/muxing.rs

Line 68 in cb3784a

/// - A connection to the remote. The `poll_event`, `flush_all` and `close` methods operate

Because the method was removed in #2669

cc @thomaseizinger
@thomaseizinger
Copy link
Contributor

Thanks! That was indeed an oversight.

The docs will re-worked here: https://github.com/libp2p/rust-libp2p/pull/2707/files#diff-1d8f8fba36155ce3fd2849bc74180b4aa5399051838235c3dcbd5b99b8ed908eR64-R71

I'll attach this issue as being fixed with #2707.

@thomaseizinger thomaseizinger linked a pull request Jun 21, 2022 that will close this issue
core/muxing: Force StreamMuxer::Substream to implement Async{Read,Write} #2707
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

core/muxing: Force StreamMuxer::Substream to implement Async{Read,Write} libp2p/rust-libp2p
2 participants
@kpp @thomaseizinger