Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib2p-uds didn't get bumped in libp2p 0.45 #2715

Closed
tomaka opened this issue Jun 20, 2022 · 7 comments · Fixed by #2720
Closed

lib2p-uds didn't get bumped in libp2p 0.45 #2715

tomaka opened this issue Jun 20, 2022 · 7 comments · Fixed by #2720

Comments

@tomaka
Copy link
Member

tomaka commented Jun 20, 2022

The current version of libp2p published on crates.io is 0.45.1.

libp2p 0.45.1 depends (amongst others) on libp2p-uds v0.32.0 and on libp2p-core v0.33.0
libp2p-uds v0.32.0, however, depends on libp2p-core v0.32.0

This means that if you depend on libp2p and enable the uds feature (it's enabled by default), you will have libp2p-core twice in your dependencies graph.

I haven't tested this, but it seems that it also renders libp2p-uds unusable, as the traits of libp2p-core v0.32 and v0.33 are considered as not the same by the compiler.

@kpp
Copy link
Contributor

kpp commented Jun 20, 2022

That's strange because libp2p-core was bumped in uds in 2ad905f

@mxinden
Copy link
Member

mxinden commented Jun 21, 2022

libp2p 0.45.1 depends (amongst others) on libp2p-uds v0.32.0 and on libp2p-core v0.33.0
libp2p-uds v0.32.0, however, depends on libp2p-core v0.32.0

Thanks. My bad. You are right. Will cut a new release of libp2p-uds and a patch release of libp2p.

As an aside, is anyone using libp2p-uds?

@mxinden
Copy link
Member

mxinden commented Jun 21, 2022

That's strange because libp2p-core was bumped in uds in 2ad905f

Yes, but I forgot to bump the libp2p-uds version itself and thus didn't cut a new libp2p-uds release.

@kpp
Copy link
Contributor

kpp commented Jun 21, 2022

Can you publish 0.45.2 after resolving this issue?

@mxinden
Copy link
Member

mxinden commented Jun 22, 2022

@kpp I am targeting libp2p v0.46.0 with #2720, is that good enough for you?

Out of curiosity, where in your stack are you using libp2p-uds?

@kpp
Copy link
Contributor

kpp commented Jun 22, 2022

is that good enough for you?

Yes

where in your stack are you using libp2p-uds

We don't use it. It's a default feature.

@thomaseizinger
Copy link
Contributor

where in your stack are you using libp2p-uds

We don't use it. It's a default feature.

Related: #2173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants