protocols/kad: Limit # of inbound substreams to 32 #2699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A remote node may still send more than 32 requests in parallel by using more than one connection or by sending more than one request per stream.
When a new inbound substream comes in and the limit of total inbound substreams is hit, try to find an old inbound substream waiting to be reused. In such case, replace the old with the new. In case no such old substream exists, drop the new one.
mxinden
commented
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A remote node may still send more than 32 requests in parallel by using more
than one connection..
First commit splits substream handling into inbound and outbound substream handling. Best reviewed commit by commit.
Links to any relevant issues
Open Questions
Change checklist