Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocols/identify: Allow at most one inbound identify push stream #2694

Merged
merged 2 commits into from Jun 7, 2022

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Jun 6, 2022

Description

An identify push contains the whole identify information of a remote
peer. Upgrading multiple inbound identify push streams is useless.
Instead older streams are dropped in favor of newer streams.

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

An identify push contains the whole identify information of a remote
peer. Upgrading multiple inbound identify push streams is useless.
Instead older streams are dropped in favor of newer streams.
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me.

Is this going towards the "remove the Upgrade traits" idea that you mentioned at some point?
Perhaps we should also build some infrastructure where protocols can define that concurrency factor of their substreams.

@mxinden
Copy link
Member Author

mxinden commented Jun 7, 2022

Is this going towards the "remove the Upgrade traits" idea that you mentioned at some point?

The lazy upgrade used in this pull request, yes. Though even if we don't go all the way, I think this is a step forward.

I will write up a proposal at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants