Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/either: Use io::Result type alias instead of renaming io::Error #2687

Merged
merged 2 commits into from Jun 3, 2022
Merged

core/either: Use io::Result type alias instead of renaming io::Error #2687

merged 2 commits into from Jun 3, 2022

Conversation

thomaseizinger
Copy link
Contributor

Description

Using the type alias is more idiomatic because it avoids renaming types on import.

Links to any relevant issues

Open Questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

mxinden
mxinden approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mxinden mxinden merged commit bd9834a into libp2p:master Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

@elenaf9 elenaf9 elenaf9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thomaseizinger @mxinden @elenaf9