Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Consider using semverver #2635

Closed
mxinden opened this issue May 9, 2022 · 5 comments
Closed

*: Consider using semverver #2635

mxinden opened this issue May 9, 2022 · 5 comments
Labels
difficulty:easy getting-started Issues that can be tackled if you don't know the internals of libp2p very well help wanted

Comments

@mxinden
Copy link
Member

mxinden commented May 9, 2022

Description

Consider using https://github.com/rust-lang/rust-semverver to enforce semantic versioning. Instructions on how to integrate semverver in CI can be found on https://github.com/rust-lang/rust-semverver#ci-setup.

Motivation

Complying with Semver makes it easier for users to consume rust-libp2p. Having an automated compliance check makes maintaining rust-libp2p easier.

Are you planning to do it yourself in a pull request?

Help wanted!
@mxinden mxinden added difficulty:easy help wanted getting-started Issues that can be tackled if you don't know the internals of libp2p very well labels May 9, 2022
@maschad maschad mentioned this issue May 12, 2022
Merged
4 tasks
@maschad
Copy link
Member

maschad commented May 12, 2022

Hey @mxinden I am giving this a shot. Please see this PR

maschad added a commit to maschad/rust-libp2p that referenced this issue May 12, 2022
@maschad
.github/: Add Semver to CI steps (libp2p#2635)
1a6fd75
maschad added a commit to maschad/rust-libp2p that referenced this issue May 23, 2022
@maschad
.github/: Add Semver to CI steps (libp2p#2635)
83149d0
maschad added a commit to maschad/rust-libp2p that referenced this issue May 23, 2022
@maschad
.github/: Add Semver to CI steps (libp2p#2635)
64ebefc
maschad added a commit to maschad/rust-libp2p that referenced this issue May 23, 2022
@maschad
.github/: Enforce semantic versioning using semverver (libp2p#2635)
0487eb1
@maschad
Copy link
Member

maschad commented May 23, 2022 •
edited

Our current version bump results in a build failure see #2647 (comment)

@mxinden
Copy link
Member Author

mxinden commented Sep 2, 2022

Instead of semverver, we could consider using https://crates.io/crates/cargo-semver-checks.

@maschad
Copy link
Member

maschad commented Sep 2, 2022

Thanks for reviving this @mxinden - I had lost track of it because of work, I agree, particularly because semverver is tightly coupled to specific nightly compiler versions and takes work to stay in sync. I will give it a try on the PR.

maschad added a commit to maschad/rust-libp2p that referenced this issue Sep 15, 2022
@maschad
.github/: Enforce semantic versioning using cargo-semver-checks (libp…
6772879 
…2p#2635)
maschad added a commit to maschad/rust-libp2p that referenced this issue Sep 17, 2022
@maschad
.github/: Enforce semantic versioning using cargo-semver-checks (libp…
acabadf 
…2p#2635)
maschad added a commit to maschad/rust-libp2p that referenced this issue Sep 17, 2022
@maschad
.github/: Enforce semantic versioning using cargo-semver-checks (libp…
bff054b 
…2p#2635)
maschad added a commit to maschad/rust-libp2p that referenced this issue Sep 17, 2022
@maschad
.github/: Enforce semantic versioning using cargo-semver-checks (libp…
97b5750 
…2p#2635)
maschad added a commit to maschad/rust-libp2p that referenced this issue Sep 17, 2022
@maschad
.github/: Enforce semantic versioning using cargo-semver-checks (libp…
f3dc22e 
…2p#2635)
maschad added a commit to maschad/rust-libp2p that referenced this issue Sep 17, 2022
@maschad
.github/: Enforce semantic versioning using cargo-semver-checks (libp…
a10872d 
…2p#2635)
maschad added a commit to maschad/rust-libp2p that referenced this issue Sep 22, 2022
@maschad
.github/: Enforce semantic versioning using cargo-semver-checks (libp…
c52c6cc 
…2p#2635)
maschad added a commit to maschad/rust-libp2p that referenced this issue Sep 24, 2022
@maschad
.github/: Enforce semantic versioning using cargo-semver-checks (libp…
6dad742 
…2p#2635)
maschad added a commit to maschad/rust-libp2p that referenced this issue Sep 30, 2022
@maschad
.github/: Enforce semantic versioning using cargo-semver-checks (libp…
09e2ef6 
…2p#2635)
maschad added a commit to maschad/rust-libp2p that referenced this issue Sep 30, 2022
@maschad
.github/: Enforce semantic versioning using cargo-semver-checks (libp…
c62e3b0 
…2p#2635)
maschad added a commit to maschad/rust-libp2p that referenced this issue Sep 30, 2022
@maschad
.github/: Enforce semantic versioning using cargo-semver-checks (libp…
b7f5cd0 
…2p#2635)
maschad added a commit to maschad/rust-libp2p that referenced this issue Oct 1, 2022
@maschad
.github/: Enforce semantic versioning using cargo-semver-checks (libp…
9002ae3 
…2p#2635)
maschad added a commit to maschad/rust-libp2p that referenced this issue Oct 9, 2022
@maschad
.github/: Enforce semantic versioning using cargo-semver-checks (libp…
290fb95 
…2p#2635)
maschad added a commit to maschad/rust-libp2p that referenced this issue Oct 10, 2022
@maschad
.github/: Enforce semantic versioning using cargo-semver-checks (libp…
6101708 
…2p#2635)
maschad added a commit to maschad/rust-libp2p that referenced this issue Oct 10, 2022
@maschad
misc/keygen: set publish to false in Cargo.toml since this is a priva…
42fc37c 
…te package (libp2p#2635)
@mxinden
Copy link
Member Author

mxinden commented Oct 12, 2022

With #2647 I am closing here.

@mxinden mxinden closed this as completed Oct 12, 2022
@umgefahren umgefahren mentioned this issue Oct 21, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:easy getting-started Issues that can be tackled if you don't know the internals of libp2p very well help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mxinden @maschad