Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Import libp2p with default-features = false #2574

Merged
merged 3 commits into from Mar 22, 2022
Merged

*: Import libp2p with default-features = false #2574

merged 3 commits into from Mar 22, 2022

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Mar 18, 2022

While not a win in most cases, it reduces compile time for tests of
individual crates.

@mxinden
*: Import libp2p with default-features = false
f5f16dc 
While not a win in most cases, it reduces compile time for tests of
individual crates.
thomaseizinger
thomaseizinger approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

Eventually, I'd like to find time for flipping this around so we don't have to deactivate default features!

@mxinden
Copy link
Member Author

mxinden commented Mar 18, 2022

Eventually, I'd like to find time for flipping this around so we don't have to deactivate default features!

👍 I would be in favor of that @thomaseizinger!

@mxinden mxinden merged commit 6cc3b4e into libp2p:master Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mxinden @thomaseizinger