Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add impl IntoIterator for MultiHandler to get access to inners #2572

Merged
merged 4 commits into from Mar 21, 2022
Merged

Add impl IntoIterator for MultiHandler to get access to inners #2572

merged 4 commits into from Mar 21, 2022

Conversation

kpp
Copy link
Contributor

@kpp kpp commented Mar 18, 2022

To access the inners of MultiHandler. This PR is required by paritytech/substrate#10370 (comment).

@kpp kpp mentioned this pull request Mar 18, 2022
Merged
mxinden
mxinden reviewed Mar 18, 2022
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Mind adding a changelog entry @kpp?

swarm/src/handler/multi.rs Outdated Show resolved Hide resolved
mxinden
mxinden approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kpp.

I hope to find time to do a release sometime this week.

@mxinden mxinden merged commit d81ad52 into libp2p:master Mar 21, 2022
@kpp kpp deleted the multihandler_intoiter branch March 22, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kpp @mxinden