Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(swarm-derive): allow mixing of ignored fields #2570

Merged
merged 4 commits into from Mar 18, 2022
Merged

fix(swarm-derive): allow mixing of ignored fields #2570

merged 4 commits into from Mar 18, 2022

Conversation

rand0m-cloud
Copy link
Contributor

Fixes #2569 and adds a test to cover the previous failure.

@rand0m-cloud rand0m-cloud force-pushed the fix-mixed-ignored-fields branch 2 times, most recently from 6a0bd6d to be407e2 Compare March 17, 2022 16:58
mxinden
mxinden approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, the clean-up and the test. Solid work! 🙏

swarm-derive/src/lib.rs Outdated Show resolved Hide resolved
@mxinden mxinden merged commit b0dc4bc into libp2p:master Mar 18, 2022
@mxinden
Copy link
Member

mxinden commented Mar 18, 2022

Tagged and published. //CC @rand0m-cloud

@rand0m-cloud rand0m-cloud deleted the fix-mixed-ignored-fields branch March 19, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

swarm-derive/: Don't fail when ignored fields are first
2 participants
@rand0m-cloud @mxinden