Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update topic_peers when peer_topics is updated #2325

Merged
merged 3 commits into from Nov 3, 2021
Merged

update topic_peers when peer_topics is updated #2325

merged 3 commits into from Nov 3, 2021

Conversation

divagant-martian
Copy link
Contributor

Small piece of code where we update peer_topics but not topic_peers

AgeManning
AgeManning approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks like this was missed in an earlier revision

mxinden
mxinden reviewed Nov 3, 2021
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you bump the patch version and include a changelog entry?

@divagant-martian
Copy link
Contributor Author

Could you bump the patch version and include a changelog entry?

Is the patch version bump required? There is an unreleased entry already in the Changelog

mxinden
mxinden approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the patch version bump required? There is an unreleased entry already in the Changelog

Ah, yes, sorry, not required.

@mxinden mxinden merged commit 8b68026 into libp2p:master Nov 3, 2021
@mxinden mxinden mentioned this pull request Nov 15, 2021
Merged
@AgeManning AgeManning deleted the peer-topics-peers-bugfix branch February 15, 2022 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

@AgeManning AgeManning AgeManning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@divagant-martian @mxinden @AgeManning