fix: allow dialing multiaddrs without peer ids #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most multiaddrs have a peer id, e.g. `/ip4/123.123.123.123/tcp/234/p2p/Qmfoo` but some cannot, e.g. `/unix/tmp/app.sock` - we should still be able to dial these addresses with the caveat that the dialer shoul have some other way of obtaining the peer id to ensure they aren't being man-in-the-middled.
|
Cross-referencing libp2p/specs#458 here for future us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most multiaddrs have a peer id, e.g.
/ip4/123.123.123.123/tcp/234/p2p/Qmfoobut some cannot, e.g./unix/tmp/app.sock- we should still be able to dial these addresses with the caveat that the dialer shoul have some other way of obtaining the peer id to ensure they aren't being man-in-the-middled.This also allows dialing
dnsaddrsthat are configured as round-robin addresses for load balancing.