Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close short-lived connections first #1509

Closed
achingbrain opened this issue Dec 4, 2022 · 0 comments · Fixed by #1517
Closed

Close short-lived connections first #1509

achingbrain opened this issue Dec 4, 2022 · 0 comments · Fixed by #1517
Labels
exp/intermediate Prior experience is likely helpful good first issue Good issue for new contributors help wanted Seeking public contribution on this issue

Comments

@achingbrain
Copy link
Member

When breaching connection limits or the max allowable event loop delay the connection manager can close some connections. It chooses the connections to close by sorting them by the sum of all tags for the remote peers. It should also sort by connection lifespan (e.g. the connection.timeline.open property) to favour long-lived connections.
@achingbrain achingbrain added the need/triage Needs initial labeling and prioritization label Dec 4, 2022
@achingbrain achingbrain mentioned this issue Dec 4, 2022
Merged
@achingbrain achingbrain added help wanted Seeking public contribution on this issue good first issue Good issue for new contributors exp/intermediate Prior experience is likely helpful and removed need/triage Needs initial labeling and prioritization labels Dec 6, 2022
maschad added a commit to maschad/js-libp2p that referenced this issue Dec 13, 2022
@maschad
fix: close short-lived connections first when pruning by tag value (l…
89fc431 
…ibp2p#1509)
maschad added a commit to maschad/js-libp2p that referenced this issue Dec 13, 2022
@maschad
fix: close short-lived connections first when pruning by tag value (l…
e0dc269 
…ibp2p#1509)
@maschad maschad mentioned this issue Dec 13, 2022
Merged
maschad added a commit to maschad/js-libp2p that referenced this issue Dec 13, 2022
@maschad
docs: updated limits doc re: closing connections (libp2p#1509)
793c59e
maschad added a commit to maschad/js-libp2p that referenced this issue Dec 16, 2022
@maschad
fix: close short-lived connections first when pruning by tag value (l…
73deff5 
…ibp2p#1509)
maschad added a commit to maschad/js-libp2p that referenced this issue Dec 16, 2022
@maschad
docs: updated limits doc re: closing connections (libp2p#1509)
014e545
achingbrain pushed a commit that referenced this issue Jan 4, 2023
@maschad
fix: close short-lived connections first when pruning by tag value (#…
40fe372 
…1517)

When choosing connections to close, choose shorter lived connections over longer lived ones.

Closes #1509
ckousik pushed a commit to ckousik/js-libp2p that referenced this issue Jan 24, 2023
@maschad @ckousik
fix: close short-lived connections first when pruning by tag value (l…
9a28abb 
…ibp2p#1517)

When choosing connections to close, choose shorter lived connections over longer lived ones.

Closes libp2p#1509
@holmesworcester holmesworcester mentioned this issue Jan 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/intermediate Prior experience is likely helpful good first issue Good issue for new contributors help wanted Seeking public contribution on this issue
Projects
js-libp2p
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: close short-lived connections first when pruning by tag value maschad/js-libp2p
1 participant
@achingbrain