This repository has been archived by the owner on May 26, 2022. It is now read-only.
add bandwidth-related metrics (for Linux and OSX) #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Apr 12, 2021
mxinden
reviewed
Apr 12, 2021
metrics.go
Outdated
| } | ||
| bytesRcvdMetric, err := prometheus.NewConstMetric(c.bytesRcvdDesc, prometheus.CounterValue, float64(bytesRcvd)) | ||
| if err != nil { | ||
| log.Errorf("creating tcp_rcvd_segments_total metric failed: %v", err) |
There was a problem hiding this comment.
Suggested change
| log.Errorf("creating tcp_rcvd_segments_total metric failed: %v", err) | |
| log.Errorf("creating tcp_rcvd_bytes metric failed: %v", err) |
metrics.go
Outdated
| @@ -108,6 +134,34 @@ func (c *aggregatingCollector) Collect(metrics chan<- prometheus.Metric) { | |||
| c.mutex.Unlock() | |||
| metrics <- c.rtts | |||
| metrics <- c.connDurations | |||
| if hasSegmentCounter { | |||
| segsSentMetric, err := prometheus.NewConstMetric(c.segsSentDesc, prometheus.CounterValue, float64(segsSent)) | |||
There was a problem hiding this comment.
Great to see NewConstMetric in use here.
marten-seemann
force-pushed
the
bandwidth-metrics
branch
from
586c623
to
9d5134f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surprisingly, we only have access to the number of bytes sent / received on OSX, there's no counter for that on Linux: https://github.com/mikioh/tcpinfo/blob/30a79bb1804bc47fa7fe29928c9109f368792a9e/sys_linux.go#L45-L69