This repository has been archived by the owner on May 26, 2022. It is now read-only.
Skip SetKeepAlivePeriod call on OpenBSD #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenBSD does not have a user-settable per-socket TCP keepalives. This changes tryKeepAlive to skip attempting set it when on OpenBSD. https://github.com/golang/go/blob/master/src/net/tcpsockopt_openbsd.go#L13-L14 This prevents thousands of `log.Errorf("Failed set keepalive period: %s", err)`'s from happening.
|
How would one set the keep alive period on OpenBSD then? I find it hard to believe it's not possible to set it at all. |
|
Root can diddle various keepalive properties to change the behavior via the sysctl, but there is no way for non-root user to do it. |
|
Ok, I guess OpenBSD users then have to live with a slightly suboptimal behavior then. |
marten-seemann
approved these changes
Jun 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenBSD does not have a user-settable per-socket TCP keepalives. This changes
tryKeepAlive to skip attempting set it when on OpenBSD.
https://github.com/golang/go/blob/master/src/net/tcpsockopt_openbsd.go#L13-L14
This prevents thousands of
log.Errorf("Failed set keepalive period: %s", err)'s from happening.