How to Add the Ed448-Goldilocks elliptic curve to the project

[mohammad-babaei]

Description

I would like to explore the possibility of adding the Ed448-Goldilocks elliptic curve support to the go-libp2p project. This would be a significant change and has the potential to enhance the security and performance of the project. I would appreciate guidance and assistance on how to make this enhancement.

Requested Changes

I would like to understand the necessary steps to add the Ed448-Goldilocks elliptic curve to the go-libp2p project. This may include modifications to cryptographic libraries, code changes, and any other related adjustments.

Questions

1. Could you provide guidance on the codebase files that would need modification for this transition?
2. Are there any compatibility concerns or potential breaking changes this might introduce?

Additional Information

Please provide any additional context, recommendations, or relevant information related to this elliptic curve change that would help me better understand the process.

Thank you for your assistance and support in considering this change. I'm looking forward to your guidance and expertise on this matter.

[Jorropo]

@mohammad-babaei the specs would need to be updated first:
https://github.com/libp2p/specs/blob/master/peer-ids/peer-ids.md#key-types
You should start with this:
https://github.com/libp2p/specs#contributions

[marten-seemann]

What @Jorropo said.

I'd like to add that it's possible to experiment with this, or even roll it out, without the blessing of the go-libp2p project. You can modify the map of key unmarshallers from your application:

go-libp2p/core/crypto/key.go

Lines 51 to 57 in 97b4ca0

	// PubKeyUnmarshallers is a map of unmarshallers by key type
	var PubKeyUnmarshallers = map[pb.KeyType]PubKeyUnmarshaller{
	pb.KeyType_RSA: UnmarshalRsaPublicKey,
	pb.KeyType_Ed25519: UnmarshalEd25519PublicKey,
	pb.KeyType_Secp256k1: UnmarshalSecp256k1PublicKey,
	pb.KeyType_ECDSA: UnmarshalECDSAPublicKey,
	}

That said, it probably makes sense to go the road of properly standardizing this, especially if you want libp2p implementations in other languages to support this as well at some point in the future. Please start a discussion in the specs repo.