New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nat: use libp2p UserAgent for the UPnP comment string #2307
Comments
This is where it comes from: Lines 221 to 227 in 305282b
It's a comment / description, so it doesn't really matter what we put there. I agree though that it would be nice to use the user agent. Want to submit a patch? |
@marten-seemann Yes. Of course :-) I'll give it a try. |
@marten-seemann It's been over two and a half months now. You promised me it would be added. Keep your promise. The task is ready. |
@marten-seemann @MarcoPolo I'm starting to think you're spamming me on purpose to avoid adding my code. |
Hi @master255 , the maintainers are not spamming you. I don't know why you make such a claim. Apologies resolving this has taken a bit longer, the team has been dealing with other issues at higher priority (see recent patch release and fixes) - I can bring this up for a discussion the maintainer call so we can bring it to a close |
@p-shahi I think such issues are better handled in writing. As it can take up to an hour of time to respond. And the conference does not have that much time. What is the purpose of this public method? I think sometimes it is necessary to change public methods. This is the case when it is necessary to change it. |
My last few responses there. Marco hasn't responded in days. Even very busy - I always find 5 minutes to reply. There's no way he doesn't have time. He probably just doesn't care. |
Finally, developers themselves can correct the code if they see a bug. |
@master255 It is a matter of priority - as you have pointed out this is a minor issue. Please don't attribute it to not caring but understand that maintainers are tasked with doing a dozen things at once. I agree that our response times need to be better as a team - that's fair. |
Hey @p-shahi can I pick this up if the team is busy? |
This is probably a minor bug.
When creating a host, there is a libp2p.UserAgent() field
It should name the port forwarded upnp with this name, not the name of the library (libp2p)
The text was updated successfully, but these errors were encountered: