Lint with golangci-lint

[estensen]

Running golangci-lint on my machine I find quite a few improvements. Would it be an idea to add the linter to CI and gradually remove warnings? I can add an Action for it.

[marten-seemann]

We’re using our Unified CI setup. Using golangci-lint was discussed and we decided against it.

[MarcoPolo]

I looked and I think I found these two references:

protocol/.github#41 (comment)

and

protocol/.github#6 (comment)

it seems like we don’t want everything from golangci-lint since sometimes it can be annoying. And it’s may lag behind releases on the underlying linters.

[marten-seemann]

There’s also ipld/ipld#92, which contains a lot of discussion.

In addition to not being up to date, golangci-lint also sometimes breaks the underlying linters. See https://twitter.com/dominikhonnef/status/1530695446007521280 for an example.